qb: Allow building with a shared lua. #7569
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm told the lua implementation is not currently in use because it was crashing, I suppose this PR doesn't offer much until it is in use... |
|
Yeah, can you make lua something that is currently not baked in by default? I am fine with merging the rest of the PR as-is as long as that change is brought about. |
v2: Disable baked in lua by default.
|
Yes, I did that. Now it will automatically detect if a system lua is available and build with it if possible. if |
|
@twinaphex Did I not understand your request? |
|
Nvm, you're just wasting my time and energy again... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows building RetroArch with the system lua instead of the builtin lua, the builtin lua will be default and the configure argument
--disable-builtinluamust be used to enable the auto detected system lua (If found).Reviewers
I have only tested that RetroArch continues to build with the builtin lua, with the system lua and without lua. I have not used retroachievements before nor do I have an account to do so. If someone can test this more thoroughly during run time it would be appreciated.
./configure --enable-lua --disable-builtinlua && make