qb: Disable the builtin lua by default. #7832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disables the builtin lua as it causes the mpv core to segfault and doesn't do anything yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disables the builtin lua as it causes the mpv core to segfault and doesn't do anything yet.
Related Issues
Conflicts with the system lua that libmpv is built against and causes a segfault (In the system lua) effectively breaking the mpv core. I don't think this is hooked up to do much because of other issues so lets disable it for now.
If anyone wants to test it they can use
--enable-lua, in the future when these issues are solved it can be enabled again by default. However there is not much point in trying until its hooked up to do anything in RetroArch...