2 link fixes for scummvm.md #643
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 22, 2021 10:11
Since fatboy.site no longer has a valid SSL certificate, I am putting the soundfont up on my own website. Added the link in the doc. Also, the screenshot for selecting the correct branch for kyra.dat is now in this repo, not hosted externally.
|
Thank you for your effort. Actually we have discussed internally and source is looking fine and SSL ended like 2-3 months ago, so it can be stay like that and you can close this pr for now. |
|
Sure! However, wouldn't it make more sense to have that screenshot up on the repo itself rather than my website? I mean the one in the kyra.dat section. |
fpscan
added a commit
that referenced
this pull request
Jul 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @fpscan in pull request #637, I am adding a link to a copy of the latest FatBoy soundfont on my own website since the official website no longer has a valid SSL certificate. Also, the screenshot for selecting the correct kyra.dat branch in the official ScummVM GitHub repo was hosted on my own website at first; I now put it onto this repo and updated the link to the image in scummvm.md.