Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for disk control interface v1 (disk display labels) #223

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

jdgleaver
Copy link
Contributor

This PR adds support for libretro disk control interface v1 (c.f. libretro/RetroArch#10019) - in particular, it enables the display of disk 'labels' when using RetroArch's Current Disk Index drop-down list to select disk images.

By default, disk labels are set to the image filename without extension - but when using M3U playlists custom labels may be set via the following syntax: DISK_FILE|DISK_LABEL. For example, this M3U file:

Valhalla & the Fortress of Eve_Disk1.adf|Game Disk
Valhalla & the Fortress of Eve_Disk2.adf|Data Disk
Valhalla & the Fortress of Eve_Disk3.adf|Level 1 Disk
Valhalla & the Fortress of Eve_Disk4.adf|Level 2 Disk
Valhalla & the Fortress of Eve_Disk5.adf|Level 3 Disk
Valhalla & the Fortress of Eve_Disk6.adf|Level 4 Disk

...will produce the following menu:

Screenshot_2020-01-17_14-39-34

If DISK_LABEL is intentionally left blank (i.e. DISK_FILE|) then only the disk index will be displayed.

Save disks generated by the #SAVEDISK: keyword are automatically assigned the label: SAVE DISK [SAVE_DISK_INDEX].

Here are some more examples:

HeroQuest - Return of the Witch Lord_Disk1.adf|HeroQuest
HeroQuest - Return of the Witch Lord_Disk2.adf|Expansion - Return of the Witch Lord
#SAVEDISK:
#SAVEDISK:

Screenshot_2020-01-17_14-48-39

Sensible Golf (1995)(Virgin)(Disk 1 of 2).adf
Sensible Golf (1995)(Virgin)(Disk 2 of 2).adf
#SAVEDISK:

Screenshot_2020-01-17_14-54-08

Secret of Monkey Island_Disk 1.adf|
Secret of Monkey Island_Disk 2.adf|
Secret of Monkey Island_Disk 3.adf|
Secret of Monkey Island_Disk 4.adf|
#SAVEDISK:

Screenshot_2020-01-17_17-37-30

@inactive123
Copy link
Contributor

Hi there @rsn8887, I think this is a good PR to merge but I'll leave the final reviewing up to you.

@rsn8887
Copy link
Collaborator

rsn8887 commented Jan 17, 2020

Looks good thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants