Makefile.libretro: -DDISABLE_THREADING for Vita #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was highlighted by @endrift in [this comment](libretro#69 (comment)). It partially solves the problems I reported in libretro#69 (most of those "undefined reference" errors).
|
Honestly -DDISABLE_THREADING should be done for all of the ports, not just the Vita one. |
sergiobenrocha2
added a commit
that referenced
this pull request
Sep 30, 2017
|
Would -DDISABLE_THREADING cause any slowdown or are the threads only emulator and gui so the emulator is stuck with 1 CPU regardless? By GUI I just mean the user interface not the video from the emulator. |
|
Though the official 3DS and Vita ports do use a second core, the libretro port does not take advantage of it regardless, so there will be no (additional) slowdown |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was highlighted by @endrift in this comment.
It partially solves the problems I reported in #69 (most of those "undefined reference" errors).