Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Util: Get rid of _to16Bit #75

Merged
merged 1 commit into from
Oct 2, 2017
Merged

Util: Get rid of _to16Bit #75

merged 1 commit into from
Oct 2, 2017

Conversation

meleu
Copy link

@meleu meleu commented Oct 1, 2017

This is the equivalent to this commit from upstream.

It solves the undefined reference to '_to16Bit' I reported in #69 .

This solution was pointed out by @endrift in this comment.

One step at a time and soon we will have mgba on PS Vita. :-)

@meleu
Copy link
Author

meleu commented Oct 1, 2017

By the way, this PR solves the problems to compile mgba for Vita (the exact description of the issue #69 ), but after compiling and installing, RetroArch crashes at launching on Vita. I think we should leave that issue open just to not lose the conversation about "making mgba core work on PS Vita".

@sergiobenrocha2
Copy link

You can use the command git cherry-pick instead, to backport stuff like that

@meleu
Copy link
Author

meleu commented Oct 1, 2017

@sergiobenrocha2 oh, thanks. Every time is time to learn a new git trick. I thought that "cherry-pick" was a slang to "carefully pick what changed here and do the equivalent there". :-)

Anyway I compiled here and everything compiled fine. Now I will try to debug/check what's causing the crash on Vita.

Best regards!

@inactive123 inactive123 merged commit abf5a18 into libretro:master Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants