-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
performance - is it as bad as reported? #572
Comments
Hmm, I wonder what they used for resampling in librosa? Pre-resampy, and
installed without libSRC, librosa would run ok, yet be very slow. Pretty
annoying if that's what they did. And, absent that, the result looks
suspicious to me; there's nothing drastically inefficient about doing
computation using numpy via librosa.
DAn.
…On Mon, May 8, 2017 at 12:27 PM, Hanan Shteingart ***@***.***> wrote:
According to this paper
<https://www.ntnu.edu/documents/1001201110/1266017954/DAFx-15_submission_43_v2.pdf/06508f48-9272-41c8-9381-7639a0240770>,
librosa performance are the worst by far among audio feature extraction
packages.
Is that true? too bad, I liked the design.
See figure 2:
[image: image]
<https://cloud.githubusercontent.com/assets/24369534/25813946/405d475c-3424-11e7-80bb-367a24ae0a1b.png>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#572>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAhs0Yh4ddBfRCZKgPBiL7V-1KKbR9vMks5r30JmgaJpZM4NULzD>
.
|
They're citing v0.3.1, so I wouldn't put much stock in the comparison. |
I've emailed the authors and asked them to share the source code and data such that I can try producing new results... |
Is there any reason to keep this issue open? |
Maybe a call for new benchmark
…On Jul 17, 2017 10:12 PM, "Brian McFee" ***@***.***> wrote:
Is there any reason to keep this issue open?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#572 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AXPZfmMNNoYm1m8eP4cT71IaPAlH8-Zkks5sO7IZgaJpZM4NULzD>
.
|
Seeing as the authors of that study have not produced source code and As mentioned above, they cite v0.3.1, which at this point, bears little similarity to the modern code base. Especially when it comes to features like resampling and constant-Q transforms, where there have been significant speedups introduced. This paper has a more recent benchmark (against 0.4.3): http://www.aes.org/e-lib/browse.cfm?elib=18769 . The load benchmark is a complicated case because of librosa's interface to |
FYI: I never heard back from the authors... |
According to this paper, librosa performance are the worst by far among audio feature extraction packages.
Is that true? too bad, I liked the design.
See figure 2:
The text was updated successfully, but these errors were encountered: