Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance - is it as bad as reported? #572

Closed
chananshgong opened this issue May 8, 2017 · 7 comments
Closed

performance - is it as bad as reported? #572

chananshgong opened this issue May 8, 2017 · 7 comments
Labels
discussion Open-ended discussion for developers and users

Comments

@chananshgong
Copy link

According to this paper, librosa performance are the worst by far among audio feature extraction packages.

Is that true? too bad, I liked the design.

See figure 2:
image

@dpwe
Copy link
Contributor

dpwe commented May 8, 2017 via email

@bmcfee
Copy link
Member

bmcfee commented May 8, 2017

They're citing v0.3.1, so I wouldn't put much stock in the comparison.

@rafaelvalle
Copy link

rafaelvalle commented May 11, 2017

I've emailed the authors and asked them to share the source code and data such that I can try producing new results...

@bmcfee
Copy link
Member

bmcfee commented Jul 17, 2017

Is there any reason to keep this issue open?

@chananshgong
Copy link
Author

chananshgong commented Jul 17, 2017 via email

@bmcfee
Copy link
Member

bmcfee commented Jul 17, 2017

Seeing as the authors of that study have not produced source code and do not report what exact features they're benchmarking only benchmark mfcc calculation, I don't feel much inclination to try reproducing their setup.

As mentioned above, they cite v0.3.1, which at this point, bears little similarity to the modern code base. Especially when it comes to features like resampling and constant-Q transforms, where there have been significant speedups introduced.

This paper has a more recent benchmark (against 0.4.3): http://www.aes.org/e-lib/browse.cfm?elib=18769 . The load benchmark is a complicated case because of librosa's interface to audioread. If you want fast loading, you can read through soundfile instead and get a speedup at the cost of losing mp3 support. Otherwise, things are roughly in the small-constant-factor ballpark that you would expect when comparing llvm/compiled code to interpreted python.

@bmcfee bmcfee added the discussion Open-ended discussion for developers and users label Sep 28, 2017
@bmcfee bmcfee closed this as completed Sep 28, 2017
@rafaelvalle
Copy link

FYI: I never heard back from the authors...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Open-ended discussion for developers and users
Development

No branches or pull requests

4 participants