[SDL2] Fixes for WAV playing <targeted to wrong branch, please delete this> #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sound and have the loudness same as other MIDI backends
Patch from Michael Day Fixes libsdl-org#511
Ensure that when playing a track it starts from the beginning.
Xcode 14.3 does not allow targeting 10.9, the minimum recommended version is 10.13 and the minimum possible version is 10.11. (cherry picked from commit ded4f11dc4741de555fdfd760de4bbb9ac1f98ab)
Patch by Alice Rowan (@AliceLR): nothings/stb#1487 Fix residue classdata bounding for f->temp_memory_required. Updates `start_decoder`'s calculation of `f->temp_memory_required` to more accurately reflect the required size of the `part_classdata` array in `decode_residue`. In `decode_residue`, the value `actual_size` is derived from the variable `n`, which is sourced from the variable `n2` in `vorbis_decode_packet_rest`. `n2` is equal to one of the blocksizes divided by 2 (of which `f->blocksize_1` will always be the greater value). For residue type 2, `decode_residue` multiplies its copy of `n` by 2 (back to the original blocksize). The faulty bounding in `start_decoder` unconditionally divides `f->blocksize_1` by 2, even for residue type 2. This patch corrects the bounding to use the full `f->blocksize_1` for residue type 2. This bug *may* have implications for anything using the alloc buffer feature, but I don't have an input that would cause this (the setup requires a much larger temp buffer than `decode_residue`). I found this bug via a heap corruption crash while fuzzing libxmp, which uses a work buffer derived from `f->temp_memory_required` instead of `alloca`. The `alloca` doesn't use `f->temp_memory_required`, so it does NOT have this bug.
Patch by Alice Rowan (@AliceLR): nothings/stb#1490 Fix broken clamp in codebook_decode_deinterleave_repeat. The clamp on the effective number of dimensions to decode in `codebook_decode_deinterleave_repeat` is trivially broken. libFuzzer managed to find some inputs that exploit this to increase the number of dimensions to be read past the end of the multiplicands array.
…Channel() (cherry picked from commit ba783cf)
because the full library is under MIT license now.
This avoids the need for settings CACHE variables, and will now show warnings messages.
.. with prowizard format loaders and depackers functionality disabled.
Taken from SDL_wave.c. Fixes playing of some WAV files that contains chunks with non-even length. WohlSoft/SDL-Mixer-X@073af71
Caught by Address Sanitizer WohlSoft/SDL-Mixer-X@4388769
|
OUCH, WRONG TARGET |
Wohlstand
changed the title
|
Fyi, it's possible to change the target branch at any time. |
I didn't found anything that could allow me that... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two bugs got been fixed:
Cymatics_-_BELL_Dusty_C.wav.zip that contains
bextchunk with 603 length, but actual size of the chunk os 604 because of a pad byte.