Add example code for dialog filter and callback #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slouken
reviewed
May 9, 2024
zturtleman
reviewed
May 9, 2024
Co-authored-by: Sam Lantinga <slouken@libsdl.org>
|
This looks good. I'm adding this and then fixing the syntax error. |
|
Okay, make sure I didn't screw this up in 3a5ce94. (Outside of this specific example: should this callback send in the filter array too, so we don't have to have a global to figure out what the |
|
I reviewed the commit and everything looked fine. One thing though, there are still |
|
SDL_Log messages should be terminated with "\n" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces libsdl-org/SDL#9729, the same description applies.
This is my first PR here, please let me know if I got something wrong!