Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: GitHub actions: check format #43

Merged
merged 4 commits into from Jan 24, 2021
Merged

CI: GitHub actions: check format #43

merged 4 commits into from Jan 24, 2021

Conversation

murraycu
Copy link
Contributor

@murraycu murraycu commented Oct 28, 2019

This requires clang-format from clang 10, because it uses the new --dry-run and --Werror options. So it uses Ubuntu 20.04.

@murraycu murraycu force-pushed the github-actions-check-format branch from dbbb53f to 4514e66 Compare Oct 29, 2019
@murraycu murraycu force-pushed the github-actions-check-format branch 5 times, most recently from 9493c1e to c67670c Compare Apr 26, 2020
@murraycu murraycu changed the title WIP: GitHub actions: check format CI: GitHub actions: check format Apr 26, 2020
@murraycu murraycu force-pushed the github-actions-check-format branch 3 times, most recently from e19b2d5 to 6dc0394 Compare Apr 26, 2020
@murraycu murraycu force-pushed the github-actions-check-format branch 2 times, most recently from bff5102 to 78d44a4 Compare Jun 30, 2020
@murraycu murraycu force-pushed the github-actions-check-format branch 3 times, most recently from e8a5bfe to 26bd88f Compare Jan 2, 2021
murraycu and others added 4 commits Jan 2, 2021
So the generated sigc++config.h will have the correct formatting.
This requires clang-format-10, which is available in ubuntu-20.04.
@murraycu murraycu force-pushed the github-actions-check-format branch from 26bd88f to f15dc63 Compare Jan 2, 2021
@murraycu murraycu requested a review from kjellahl Jan 2, 2021
@kjellahl
Copy link
Contributor

@kjellahl kjellahl commented Jan 3, 2021

From https://gitlab.gnome.org/GNOME/glibmm/-/issues/84:

Pavlo Solntev:
This test fails for some jobs but not for others.
Not sure if this is a CI issue but it looks like it is irreproducible. Some sort of random.

Me:
This is why I dislike CI. It's supposed to report errors in recently pushed
commits, but usually when a test fails, it's because of a temporary problem
in the test environment.

I'm not very fond of CI. The basic idea is excellent, but too often it fails for
reasons unrelated to recently pushed commits.

If you want to add the clang-format test, it's alright with me.

@murraycu murraycu merged commit 0013fb8 into master Jan 24, 2021
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants