parse multiline when loading dump #355
Conversation
SQLite dumps are often multi-line, so accumulate on a buffer and only send when the line ends with ; Fixes libsql#354
There was a problem hiding this comment.
Pretty sure it won't work, rusqlite will only execute the first statement on execute(). You probably want to use execute_batch() instead, in line 97: https://docs.rs/rusqlite/latest/rusqlite/struct.Connection.html#method.execute_batch, which is syntactic sugar that lets you split statements. It only works for statements without params, but we're only using text statements here, so it will work.
And while at it, consider renaming line to something like statements? It's no longer a single line which makes the code rather confusing. curr is what's actually a single line of code in the new form.
|
there's only a single statement, @psarna. |
|
ah! My bad |
|
Side note, are we sure the dumps always include at most 1 statement in the dump? Because current code would break on more than 1 in a single line, which is a preexisting issue |
|
yes, we are. (sqlite generates them like that). |
|
bors merge |
|
Build succeeded:
|
SQLite dumps are often multi-line, so accumulate on a buffer and only send when the line ends with ;