This repository was archived by the owner on Oct 18, 2023. It is now read-only.
reserve table names #381
Merged
reserve table names #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psarna
reviewed
May 4, 2023
psarna
reviewed
May 4, 2023
sqld/src/query_analysis.rs
Outdated
| None | ||
| } else { | ||
| Some(StmtKind::Write) | ||
| } |
There was a problem hiding this comment.
I also can't resist posting that this whole function body can be replaced with the following idiomatic beauty:
fn write_if_not_reserved(name: &QualifiedName) -> Option<StmtKind> {
is_reserved_tbl(name).then_some(StmtKind::Write)
}(obviously non-blocking though)
some tables come from libSQL and cannot be deleted. Others, are usually associated with backups and internal functions and should also not be deleted. A long term better strategy is to allow users to specify which tables cannot be dropped, but litestream is widespread enough, and simple enough, that we can assume that if it is in use, we don't want those tables to be dropped. So a static list works for now.
psarna
approved these changes
May 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some tables come from libSQL and cannot be deleted. Others, are usually associated with backups and internal functions and should also not be deleted.
A long term better strategy is to allow users to specify which tables cannot be dropped, but litestream is widespread enough, and simple enough, that we can assume that if it is in use, we don't want those tables to be dropped. So a static list works for now.