Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad changelog #28

Closed
remicollet opened this issue Dec 29, 2016 · 2 comments
Closed

Bad changelog #28

remicollet opened this issue Dec 29, 2016 · 2 comments
Labels

Comments

@remicollet
Copy link

See https://pecl.php.net/package-changelog.php?package=vips

All versions have: - First stable release.

Indeed you correctly add each new release as <release> in <changelog>, but pecl web site only takes the <notes> in the top part.

@jcupitt
Copy link
Member

jcupitt commented Dec 30, 2016

Ah OK, I thought the notes were API notes rather than a changelog. I'll try and fix this for 1.0.4. Thanks!

jcupitt added a commit to libvips/php-vips-ext that referenced this issue Dec 30, 2016
- only lock libvips if we're running inside apache
- use the sapi error logger for the warning message
- include the binary API version in the .soname

also, the notes section at the top of package.xml should repeat the most
recent changelog notes

see

libvips/php-vips#27

libvips/php-vips#28
@jcupitt
Copy link
Member

jcupitt commented Dec 30, 2016

OK, fixed in 1.0.4. Thanks!

@jcupitt jcupitt closed this as completed Dec 30, 2016
@jcupitt jcupitt added the bug label Dec 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants