Skip to content

Conversation

genio
Copy link
Member

@genio genio commented Oct 18, 2016

Use lexical file handles and ensure =cut terminates POD. Only cleanup whitespace on lines within functions that filehandles were updated in.

Please ignore all of the whitespace noise in the PR.

-- Chase

… whitespace on lines within functions that filehandles were updated in
Copy link
Contributor

@tomhukins tomhukins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had a quick glance over this, but even ignoring whitespace, the combination of filehandle changes and code reformatting makes it hard to check.

I can't see anything obviously bad here.

@genio
Copy link
Member Author

genio commented Oct 19, 2016

@tomhukins Yea, sorry about that. You can see it a bit more easily via ff8f923?w=1

The ?w=1 addition at the end of the URL removes a lot of pure whitespace changes to help un-cloud the vision.

This PR will likely need to be re-worked once @oalders merges his PR to Dist::Zilla-ify the build.

Once he's done, I'll fix this up accordingly. I would suspect the meat of the changes to remain the same, so any review is still appreciated!

@oalders
Copy link
Member

oalders commented Oct 19, 2016

Great stuff!

@oalders oalders merged commit 2d45cf5 into libwww-perl:master Oct 19, 2016
@genio genio deleted the lexify-handles branch October 19, 2016 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants