- Added warnings pragma as recommended by CPANTS. #40
Conversation
|
Hi @manwar. Thanks for this! Should we add |
|
Hi @oalders That's brilliant idea and good catch. Best Regards, |
|
@manwar I apologize for losing track of this PR. Would you be able to resolve the conflicts and force-push your commits again? |
|
Sure in a moment |
manwar
force-pushed
the
add-warnings-pragma
branch
from
64bcaa9 to
0ee372e
Compare
| @@ -1,6 +1,8 @@ | |||
| package HTTP::Cookies::Microsoft; | |||
|
|
|||
| use strict; | |||
| use warnings; | |||
| use vars qw(@ISA); | |||
There was a problem hiding this comment.
Why's the legacy vars pragma being introduced? @ISA is declared correctly with our a few lines down. Though something like parent might be better still it's out of the scope of this PR.
|
@manwar is the feedback something you'd like to address? I promise to keep track of the PR this time. 😢 |
Sure, I will look into this weekend, promise. |
manwar
force-pushed
the
add-warnings-pragma
branch
from
0ee372e to
5b1a710
Compare
|
This is all messed up. I would rather create fresh pull request. Please ignore this pull request. |
Hi,
Please review the PR.
Many Thanks.
Best Regards,
Mohammad S Anwar