Skip to content

Conversation

tomhukins
Copy link
Contributor

HTTP::Cookies does not support Public Suffix and allows servers to set cookies under a top level domain. This change:

  • includes TODO tests to demonstrate the problem
  • documents the problem
  • suggests HTTP::CookieJar::LWP as an alterative

Copy link
Member

@genio genio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a more than reasonable documentation change until the underlying issue can be fixed.

HTTP::CookieJar makes use of Mozilla::PublicSuffix if it's installed: https://metacpan.org/pod/HTTP::CookieJar#Public-suffixes

@oalders
Copy link
Member

oalders commented Oct 12, 2016

Thanks!

@oalders oalders merged commit 692e0c1 into libwww-perl:master Oct 12, 2016
@tomhukins tomhukins deleted the publicsuffix branch October 17, 2016 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants