Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "set dist trusty for old perls" #294

Merged
merged 8 commits into from
Mar 27, 2020
Merged

Conversation

oalders
Copy link
Member

@oalders oalders commented Mar 27, 2020

Reverts #279

@oalders
Copy link
Member Author

oalders commented Mar 27, 2020

The failing tests are in xt/author/live

@coveralls
Copy link

coveralls commented Mar 27, 2020

Pull Request Test Coverage Report for Build 318

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 94.118%

Totals Coverage Status
Change from base Build 307: 0.9%
Covered Lines: 736
Relevant Lines: 782

💛 - Coveralls

@skaji
Copy link
Member

skaji commented Mar 27, 2020

https://travis-ci.org/github/libwww-perl/WWW-Mechanize/builds/667636368

$ make TEST_VERBOSE=1 TEST_FILES='xt/author/live/*.t' test || true
PERL_DL_NONLAZY=1 "/home/travis/perl5/perlbrew/perls/5.10/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(1, 'blib/lib', 'blib/arch')" xt/author/live/*.t
xt/author/live/encoding.t ... 
not ok 1 - Test::Needs modules available
1..1
# Failed test 'Test::Needs modules available'
# at /home/travis/perl5/perlbrew/perls/5.10/lib/site_perl/5.10.1/Test/Needs.pm line 96.
# Need LWP::Protocol::https due to RELEASE_TESTING
# Looks like you failed 1 test of 1.
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests 
xt/author/live/wikipedia.t .. 
1..1
not ok 1 - Test::Needs modules available
# Need LWP::Protocol::https due to RELEASE_TESTING
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests 
Test Summary Report
-------------------
xt/author/live/encoding.t (Wstat: 256 Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
xt/author/live/wikipedia.t (Wstat: 256 Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
Files=2, Tests=2,  1 wallclock secs ( 0.01 usr  0.01 sys +  0.05 cusr  0.00 csys =  0.07 CPU)
Result: FAIL
Failed 2/2 test programs. 2/2 subtests failed.

5.10 and 5.12 fail because Test::Needs and LWP::Protocol::https are not available.

@oalders oalders requested a review from skaji March 27, 2020 15:01
Copy link
Member

@skaji skaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! @oalders

@oalders
Copy link
Member Author

oalders commented Mar 27, 2020

Thanks for the review and the troubleshooting @skaji!

@oalders oalders merged commit ce1cbd8 into master Mar 27, 2020
@oalders oalders deleted the revert-279-dist-trusty branch March 27, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants