Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not throw CryptoException if EC KeyBuilder.buildKey() does not match a known curve #158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

llogar
Copy link

@llogar llogar commented May 29, 2020

The curve parameters can in any case be set later via the ECKeyImpl.setX().

This way one can for example use Brainpool curves with IsoApplet & OpenSC.

Before:

$ pkcs11-tool --login --pin 648219 --keypairgen --key-type EC:brainpoolP320r1 --label test_ec --id ec
Using slot 0 with a present token (0x0)
error: PKCS11 function C_GenerateKeyPair failed: rv = CKR_GENERAL_ERROR (0x5)
Aborting.

After:

$ pkcs11-tool --login --pin ****** --keypairgen --key-type EC:brainpoolP320r1 --label test_ec --id ec
Using slot 0 with a present token (0x0)
Key pair generated:
Private Key Object; EC
  label:      test_ec
  ID:         ec
  Usage:      sign, derive
Public Key Object; EC  EC_POINT 320 bits
  EC_POINT:   045104bd63ad7b54316824c09eaf02a890e64878d9650f0bb098fbadf2a8732de2ff9917afb0199dca09bb2d77c3297c2a81083e71bddc3c7e49ff9910ef5673f15b88a924bdb1ee8649dcbaaeff7540d08fd7
  EC_PARAMS:  06092b2403030208010109
  label:      test_ec
  ID:         ec
  Usage:      verify, derive

…ch a known curve

The curve parameters can in any case be set later via the ECKeyImpl.setX().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants