Restore schema() type safety by fixing generic type alias misuse
#371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type arguments for a generic type alias must be provided at every use site, or the missing arguments will default to `Any`, which gives no type safety. Fixes lidatong#370. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
lidatong
approved these changes
Aug 14, 2022
12 tasks
bruxisma
referenced
this pull request
in ixm-one/pytest-cmake-presets
Jul 20, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [dataclasses-json](https://togithub.com/lidatong/dataclasses-json) | `0.5.8` -> `0.5.12` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>lidatong/dataclasses-json (dataclasses-json)</summary> ### [`v0.5.12`](https://togithub.com/lidatong/dataclasses-json/releases/tag/v0.5.12) [Compare Source](https://togithub.com/lidatong/dataclasses-json/compare/v0.5.9...v0.5.12) ##### What's Changed - Fix multiline scripts in CI by [@​george-zubrienko](https://togithub.com/george-zubrienko) in [https://github.com/lidatong/dataclasses-json/pull/439](https://togithub.com/lidatong/dataclasses-json/pull/439) **Full Changelog**: lidatong/dataclasses-json@v0.5.11...v0.5.12 ### [`v0.5.9`](https://togithub.com/lidatong/dataclasses-json/releases/tag/v0.5.9) [Compare Source](https://togithub.com/lidatong/dataclasses-json/compare/v0.5.8...v0.5.9) #### What's Changed - feat: add formalized issue template by [@​s-vitaliy](https://togithub.com/s-vitaliy) in [https://github.com/lidatong/dataclasses-json/pull/417](https://togithub.com/lidatong/dataclasses-json/pull/417) - Fixing bug in decoder eval for optional fields by [@​rpmcginty](https://togithub.com/rpmcginty) in [https://github.com/lidatong/dataclasses-json/pull/354](https://togithub.com/lidatong/dataclasses-json/pull/354) - Fix type order relevance for union wrapping 2 types by [@​george-zubrienko](https://togithub.com/george-zubrienko) in [https://github.com/lidatong/dataclasses-json/pull/419](https://togithub.com/lidatong/dataclasses-json/pull/419) - Fix autocomplete when using annotation by [@​george-zubrienko](https://togithub.com/george-zubrienko) in [https://github.com/lidatong/dataclasses-json/pull/411](https://togithub.com/lidatong/dataclasses-json/pull/411) - Add support for enhanced builtin instantiation by [@​rpmcginty](https://togithub.com/rpmcginty) in [https://github.com/lidatong/dataclasses-json/pull/375](https://togithub.com/lidatong/dataclasses-json/pull/375) - Restore `schema()` type safety by fixing generic type alias misuse by [@​andersk](https://togithub.com/andersk) in [https://github.com/lidatong/dataclasses-json/pull/371](https://togithub.com/lidatong/dataclasses-json/pull/371) #### New Contributors - [@​s-vitaliy](https://togithub.com/s-vitaliy) made their first contribution in [https://github.com/lidatong/dataclasses-json/pull/417](https://togithub.com/lidatong/dataclasses-json/pull/417) - [@​george-zubrienko](https://togithub.com/george-zubrienko) made their first contribution in [https://github.com/lidatong/dataclasses-json/pull/419](https://togithub.com/lidatong/dataclasses-json/pull/419) - [@​andersk](https://togithub.com/andersk) made their first contribution in [https://github.com/lidatong/dataclasses-json/pull/371](https://togithub.com/lidatong/dataclasses-json/pull/371) **Full Changelog**: lidatong/dataclasses-json@v0.5.8...v0.5.9 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ixm-one/pytest-cmake-presets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNDQuMiIsInVwZGF0ZWRJblZlciI6IjM2LjguMTEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type arguments for a generic type alias must be provided at every use site, or the missing arguments will default to
Any, which gives no type safety.Fixes #370.