Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-TICKET - upgrade graph api endpoint to use v10.0 instead of deprec… #21

Merged
merged 2 commits into from
Apr 13, 2021

Conversation

austin-rausch
Copy link
Contributor

…ated v3.0

@coveralls
Copy link

coveralls commented Apr 13, 2021

Pull Request Test Coverage Report for Build 69

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 65: 0.0%
Covered Lines: 38
Relevant Lines: 38

💛 - Coveralls

@austin-rausch
Copy link
Contributor Author

austin-rausch commented Apr 13, 2021

v3.0 has been past the "Expiration Date" for a while, the version change logs can be found here: https://developers.facebook.com/docs/graph-api/changelog/versions

The old links in the README were invalid, and the facebook developer docs have three different pages on managing test users:

  1. https://developers.facebook.com/docs/graph-api/reference/v10.0/test-account
  2. https://developers.facebook.com/docs/graph-api/reference/v10.0/test-user
  3. https://developers.facebook.com/docs/graph-api/reference/v10.0/application/accounts

I opted to go with the third one, because it is listed on this page as supporting:

  • Create new test user accounts for an app.
  • Get a list of existing test users associated with an app.
  • Get a valid access token for each test user.
  • Associate and disassociate existing test users with an app.
  • Get a URL to use to login as a test user.

Which lines up / exceeds what this package is intended to do.

I was able to verify this using the dev credentials.

This was not fun to do, I ran into the api rate limits several times, and I am now mentally exhausted.

I'll bump a major version in another PR, then update the monitor deps. (doing a major version because I can't really verify what has changed in the response types since the docs links are dead, figure its safer this way.)

@austin-rausch austin-rausch merged commit fc3a4aa into master Apr 13, 2021
@austin-rausch austin-rausch deleted the upgrade-fb-graph-api-version branch April 13, 2021 21:38
@austin-rausch austin-rausch mentioned this pull request Apr 13, 2021
Copy link
Member

@hemp hemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants