feat: add subject param #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7224863043
💛 - Coveralls |
nicolls1
approved these changes
Dec 15, 2023
aecorredor
reviewed
Dec 15, 2023
Comment on lines
+125
to
+128
| /** | ||
| * If accessing a file owned by a subject, it is recommended to | ||
| * specify the subject id here. | ||
| */ |
There was a problem hiding this comment.
Why is it "recommended" and not enforced?
There was a problem hiding this comment.
Because someone with a very permissive policy won't necessarily need it.
jkdowdle
approved these changes
Dec 15, 2023
|
🎉 This PR is included in version 11.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions
bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
See code.
Screenshots