Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Invite Loading State #529

Merged
merged 1 commit into from
Feb 14, 2024
Merged

feat: Add Invite Loading State #529

merged 1 commit into from
Feb 14, 2024

Conversation

sternetj
Copy link
Contributor

Changes

  • Adds the ability to set some loading state for an incoming invite
  • Adds logic to the login screen to disable and trigger a loading wheel when an invite is being loaded
  • Adds the ability to inspect the invitation error with a long press

Screenshots

invitation-state.mov

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7903939472

Details

  • -1 of 16 (93.75%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 85.095%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/screens/LoginScreen.tsx 6 7 85.71%
Totals Coverage Status
Change from base Build 7820461714: 0.03%
Covered Lines: 3683
Relevant Lines: 4205
💛 - Coveralls

bruce-glazier
bruce-glazier approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@bruce-glazier bruce-glazier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This should help tremendously.

@sternetj sternetj merged commit 7ca29b5 into master Feb 14, 2024
3 checks passed
@sternetj sternetj deleted the add-invite-loading-state branch February 14, 2024 16:24
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 11.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Has been released to the package repository (NPM, etc) label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruce-glazier bruce-glazier bruce-glazier approved these changes

@rob-snyder rob-snyder Awaiting requested review from rob-snyder

Assignees
No one assigned
Labels
released Has been released to the package repository (NPM, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sternetj @coveralls @bruce-glazier