Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@clayui/css form-group-sm with contenteditable form-control doesn't expand #4164

Closed
pat270 opened this issue Jul 9, 2021 · 1 comment · Fixed by #4168
Closed

@clayui/css form-group-sm with contenteditable form-control doesn't expand #4164

pat270 opened this issue Jul 9, 2021 · 1 comment · Fixed by #4168
Assignees
@pat270
Labels
3.x comp: clay-css Issues related to Clay CSS type: bug Issues reporting that Component is not doing what should be done
Milestone
LPS-130572 - Bi-w...

Comments

@pat270
Copy link
Member

pat270 commented Jul 9, 2021 •
edited
Loading

form-group-sm

The Markup:

<div class="form-group-sm">
  <div contenteditable="true" class="form-control"><div>
</div>

Some notes: we need to reset min-height: 0 and set height: auto for form-control in form-group-sm.
@pat270 pat270 added type: bug Issues reporting that Component is not doing what should be done comp: clay-css Issues related to Clay CSS 3.x labels Jul 9, 2021
pat270 added a commit to pat270/liferay-portal that referenced this issue Jul 11, 2021
@pat270
LPS-135182 frontend-css-cadmin-web adds work around for contenteditab…
207adf1 
…le form-control not expanding with text

liferay/clay#4164
pat270 added a commit to pat270/liferay-portal that referenced this issue Jul 11, 2021
@pat270
LPS-135182 frontend-css-cadmin-web adds work around for contenteditab…
748c82b 
…le form-control not expanding with text

liferay/clay#4164
victorg1991 pushed a commit to victorg1991/liferay-portal that referenced this issue Jul 12, 2021
@pat270 @victorg1991
LPS-135182 frontend-css-cadmin-web adds work around for contenteditab…
203cbd5 
…le form-control not expanding with text

liferay/clay#4164
brianchandotcom pushed a commit to brianchandotcom/liferay-portal that referenced this issue Jul 12, 2021
@pat270 @brianchandotcom
LPS-135182 frontend-css-cadmin-web adds work around for contenteditab…
956ffbf 
…le form-control not expanding with text

liferay/clay#4164
@pat270 pat270 self-assigned this Jul 15, 2021
pat270 added a commit to pat270/clay that referenced this issue Jul 15, 2021
@pat270
fix(@clayui/css): Forms form-group-sm div.form-control should be 32…
eb987a1 
…px tall and grow to fix content inside, similar to a textarea element

fixes liferay#4164
@pat270 pat270 mentioned this issue Jul 15, 2021
Merged
@matuzalemsteles matuzalemsteles mentioned this issue Jul 28, 2021
Closed
@github-actions
Copy link

This issue has been merged and will be released in DXP at https://issues.liferay.com/browse/LPS-130572

@matuzalemsteles matuzalemsteles mentioned this issue Jul 29, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pat270 pat270

Labels
3.x comp: clay-css Issues related to Clay CSS type: bug Issues reporting that Component is not doing what should be done
Projects
None yet
Milestone
LPS-130572 - Bi-weekly Clay release J...
2 participants
@pat270 @matuzalemsteles