fix(@clayui/core): Fixes bug when rendering the last columns visibility cell for dynamic rendering #5822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty cell for dynamic rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up #5817
I had only done the test for the case of static rendering but had not done the coverage for the case of dynamic rendering, an important point is that we do this as a speculation of the size of the items within a row but this value can change if necessary in the cell, I believe that the best thing is for the developer to avoid cases like this so as not to break other table behaviors along with collection, so it always passes the items that will be rendered. This is also great for recommending that they are pure functions and have no side effects.