Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@clayui/tree-view): LPD-1277 TreeView with checkbox need a label #5851

Merged
merged 2 commits into from
Aug 8, 2024
Merged

fix(@clayui/tree-view): LPD-1277 TreeView with checkbox need a label #5851

merged 2 commits into from
Aug 8, 2024

Conversation

ilzamcmed
Copy link
Member

@ilzamcmed ilzamcmed commented Aug 6, 2024 •
edited
Loading

Jira ticket

https://liferay.atlassian.net/browse/LPD-1277

Commits

  • fix(@clayui/tree-view): LPD-1277 Add id to correlate label with checkbox
  • fix(@clayui/tree-view): LPD-1277 Add id prop to correlate label with checkbox
  • fix(@clayui/tree-view): LPD-1277 Update snapshots

@ilzamcmed
Copy link
Member Author

Hey @matuzalemsteles @pat270
This PR is ready for review!
Thanks!

matuzalemsteles
matuzalemsteles approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@matuzalemsteles matuzalemsteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matuzalemsteles matuzalemsteles merged commit a1503fa into liferay:master Aug 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matuzalemsteles matuzalemsteles matuzalemsteles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilzamcmed @matuzalemsteles