fix(@clayui/form): LPD-36696 DualListBox adds children and don't disable left right buttons if no items are selected #5874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble left right buttons if no items are selected
…isable left / right arrows if it exceeds max items
|
Just an update on this, I spoke to Patrick and will get to work on it, should have something this week. |
…ft and Right side with error message
|
I'm moving the entire validation system to the component as well as the error message with translation support, also adding new APIs to configure the maximum number of items for both sides. |
|
Hey @pat270 What do you think of these changes? Is this a rule that can be applied to all cases? |
|
@matuzalemsteles It's not working correctly for me for some reason. Here is a gif of what I'm seeing. |
…ly disable buttons and error message
|
@matuzalemsteles I got it to work. Some of the left/right error stuff just needed to be swapped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://liferay.atlassian.net/browse/LPD-36696
I added children to the component so we can pass in things like an error message. I also removed disabling the move buttons if length is 0.