Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Building using master branch doesn't working in current version #58

Open
diegonvs opened this issue Apr 4, 2018 · 2 comments
Open

Building using master branch doesn't working in current version #58

diegonvs opened this issue Apr 4, 2018 · 2 comments

Comments

@diegonvs
Copy link
Contributor

diegonvs commented Apr 4, 2018

Trying to fix example pages, i've gotten a lot of errors using gulp scripts:

  • My first solution was downgrade node and gulp versions to solve startup gulp problems but i've noticed that this project is using senna master branch and running npm install to his dependencies resulting a lot of errors caused by downgrading node in development machine.

  • My second tentative was downgrading senna version to a 1.x.x tag. I've gotten gulp working perfect but a lot of problems have appeared: like we cannot get updated 'docs' using this senna version in deploy task due outdated node version and a lot of build errors during installation.

Reviewing commits in this repo i've noticed that:

  1. Note that Update Custom Screen docs #41 and broken link to Liferay.com #49 was not "merged" in current sennajs.com website.

  2. https://sennajs.com/api is outdated since 2016.

Conclusion:

I think that we have three alternatives:

  • Send pull requests directly to wedeploy branch
  • Normalize tooling in this repo to make a quality api docs and website
  • Migrate to electric3 using electric branch as entry point.
diegonvs added a commit to diegonvs/sennajs.com that referenced this issue Apr 5, 2018
@diegonvs diegonvs mentioned this issue Apr 5, 2018
diegonvs added a commit to diegonvs/sennajs.com that referenced this issue Apr 5, 2018
@brunobasto
Copy link

@diegonvs, can we close this? what's the status?

@diegonvs
Copy link
Contributor Author

Isn't on my roadmap change website's infra on sennajs.com, but we can include this. Using gatsby-boilerplate for example. What do you think about it?

/cc @jbalsas

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants