PowerPC Support #645
Merged
PowerPC Support #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internal context reg mapping
* Modified sleigh patch script to generate patches for multiple .sinc files * update README with new examples of sleigh patch script invocation * add ppc register definition * add ppc sleigh patches * fix issue with remill_insn_size definition * regenerate sleigh patches for PPC * update CMakeLists.txt to include PPC patches
|
I believe I've addressed everything so far. Any comment that I wasn't sure about or requires a second opinion has been left unresolved. You might have to click the "load more" above to see the comments since there's a lot of activity on this PR. |
Ninja3047
reviewed
Feb 1, 2023
2over12
approved these changes
Feb 2, 2023
lkorenc
approved these changes
Feb 2, 2023
| static std::vector<size_t> CollectIntraProcTransfers(const BlockExit &exit) { | ||
| IntraProcTransferCollector collector; | ||
| std::visit(collector, exit); | ||
| return collector.targets; |
There was a problem hiding this comment.
Suggested change
| return collector.targets; | |
| return std::move(collector.targets); |
I think?
| @@ -297,12 +304,17 @@ class SleighLifter::PcodeToLLVMEmitIntoBlock : public PcodeEmit { | |||
| // Generic sleigh arch | |||
| std::vector<std::string> user_op_names; | |||
|
|
|||
| llvm::BasicBlock *entry_block; | |||
There was a problem hiding this comment.
More in case someone introduces a new ctor and forgets about this attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.