Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making DefaultController work with Symfony 2.3 #37

Merged
merged 1 commit into from
Jan 31, 2017

Conversation

kidatsy
Copy link
Contributor

@kidatsy kidatsy commented Jan 30, 2017

Pre Symfony 2.6 (I think) $this->redirectToRoute() was satisfied by $this->redirect($this->generateUrl()). Making this edit to work with Symfony 2.3. It might be worthwhile to check version by looking at Symfony\Component\HttpKernel\Kernel::VERSION, as per http://stackoverflow.com/questions/16846189/how-to-know-which-version-of-symfony-i-have#16846325

Pre Symfony 2.6 (I think) `$this->redirectToRoute()` was satisfied by `$this->redirect($this->generateUrl())`. Making this edit to work with Symfony 2.3. It might be worthwhile to check version by looking at `Symfony\Component\HttpKernel\Kernel::VERSION`, as per http://stackoverflow.com/questions/16846189/how-to-know-which-version-of-symfony-i-have#16846325
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.034% when pulling 4a7f771 on kidatsy:master into 79b329c on lightSAML:master.

@tmilos tmilos merged commit 2cb00e7 into lightSAML:master Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants