Sensiolabs insight fixes

src/LightSaml/SpBundle/Controller/DefaultController.php

@@ -43,7 +43,7 @@ public function discoveryAction()
     public function loginAction(Request $request)
     {
         $idpEntityId = $request->get('idp');
-        if (null == $idpEntityId) {
+        if (null === $idpEntityId) {
             return $this->redirectToRoute($this->container->getParameter('lightsaml_sp.route.discovery'));
         }
 

src/LightSaml/SpBundle/Security/Authentication/Provider/LightsSamlSpAuthenticationProvider.php

@@ -100,11 +100,11 @@ public function authenticate(TokenInterface $token)
             $user = $this->createUser($token);
         }
 
-        if (null == $user && $this->force) {
+        if (null === $user && $this->force) {
             $user = $this->createDefaultUser($token);
         }
 
-        if (null == $user) {
+        if (null === $user) {
             $ex = new AuthenticationException('Unable to resolve user');
             $ex->setToken($token);
 
@@ -142,21 +142,21 @@ public function supports(TokenInterface $token)
     /**
      * @param SamlSpResponseToken $token
      *
-     * @return UserInterface|null
+     * @return UserInterface
      *
      * @throws UsernameNotFoundException
      */
     private function loadUser(SamlSpResponseToken $token)
     {
-        if (null == $this->usernameMapper || null == $this->userProvider) {
+        if (null === $this->usernameMapper || null === $this->userProvider) {
             throw new UsernameNotFoundException();
         }
 
         $username = $this->usernameMapper->getUsername($token->getResponse());
 
         $user = $this->userProvider->loadUserByUsername($username);
 
-        if (false == $user instanceof UserInterface) {
+        if (false === $user instanceof UserInterface) {
             throw new \LogicException('User provider must return instance of UserInterface');
         }
 
@@ -170,13 +170,13 @@ private function loadUser(SamlSpResponseToken $token)
      */
     private function createUser(SamlSpResponseToken $token)
     {
-        if (null == $this->userCreator) {
-            return null;
+        if (null === $this->userCreator) {
+            return;
         }
 
         $user = $this->userCreator->createUser($token->getResponse());
 
-        if ($user && false == $user instanceof UserInterface) {
+        if ($user && false === $user instanceof UserInterface) {
             throw new \LogicException('User creator must return instance of UserInterface or null');
         }
 
@@ -219,7 +219,7 @@ private function createDefaultUser(SamlSpResponseToken $token)
             }
         }
 
-        return null;
+        return;
     }
 
     /**
@@ -229,7 +229,7 @@ private function createDefaultUser(SamlSpResponseToken $token)
      */
     private function getAttributes(SamlSpResponseToken $token)
     {
-        if (null == $this->attributeMapper) {
+        if (null === $this->attributeMapper) {
             return [];
         }