Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions to be able generate javadoc for akka-http-core #40

Merged
merged 1 commit into from
Jun 25, 2014

Conversation

bantonsson
Copy link
Contributor

No description provided.

@ktoso
Copy link
Contributor

ktoso commented Jun 25, 2014

Heroic effort @bantonsson :-)
LGTM

@drewhk
Copy link

drewhk commented Jun 25, 2014

So Let's Greet The Monster :)

import language.postfixOps
Map() ++ c.getDeclaredClasses.filterNot(_.getName contains "anon").map(x ⇒ x.getName -> x)
Map() ++ c.getDeclaredClasses.filterNot(x => filter && (x.getName contains "anon")).map(x ⇒ x.getName -> x)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

collect?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toMap?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

bantonsson added a commit that referenced this pull request Jun 25, 2014
…http-core-ban

Additions to be able generate javadoc for akka-http-core
@bantonsson bantonsson merged commit e3cf886 into master Jun 25, 2014
@bantonsson bantonsson deleted the wip-adding-features-for-akka-http-core-ban branch June 25, 2014 13:42
@@ -32,7 +32,11 @@ trait BaseComments { this: TransformCake ⇒
def apply(pos: Position, text: String) = {
val ll = text.replaceAll("\n[ \t]*", "\n ").split("\n")
.map {
case See(prefix, link) ⇒ prefix + link
case See(prefix, link) ⇒
if (link.startsWith("http://"))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid point. I'll add it for the 0.9 version. This has been merged and published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants