Skip to content
This repository was archived by the owner on Jun 6, 2025. It is now read-only.

Conversation

andreaTP
Copy link
Contributor

Enforce a consistent code style, in the sdk at least.
To enable a proper review I haven't applied the command yet, we can schedule a moment in time to do so.

Copy link
Member

@octonato octonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, always good to have it.

@octonato
Copy link
Member

For the record, I applied locally and new format looks good.

Copy link
Member

@pvlugter pvlugter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good to have automatic formatting. Go ahead and reformat.

@andreaTP
Copy link
Contributor Author

I'll do it, but, I would prefer to first merge #43 given the number of headaches that PR gave me.

@andreaTP andreaTP merged commit 0aa8daa into lightbend:main Jun 21, 2021
andreaTP added a commit that referenced this pull request Jun 24, 2021
* Setup an automatic formatter

* better

* check

* Prettier

* turn the CI green to have reviews

* fix package-lock.json

* format
@tsonny
Copy link
Contributor

tsonny commented Jun 24, 2021

YAH!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants