Skip to content

Chore: update documentation 2 #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 9, 2019
Merged

Chore: update documentation 2 #104

merged 9 commits into from
Dec 9, 2019

Conversation

blumendorf
Copy link
Contributor

@blumendorf blumendorf commented Dec 5, 2019 •
edited
Loading

  • Removed MODAL_... constants
  • Doc updates.

@blumendorf blumendorf requested a review from manuelbieh December 6, 2019 10:23
@blumendorf blumendorf marked this pull request as ready for review December 6, 2019 10:23
@blumendorf blumendorf requested a review from drinchev December 6, 2019 10:24
drinchev
drinchev approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@drinchev drinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!! 👏

@blumendorf blumendorf merged commit dbe61e9 into alpha Dec 9, 2019
@blumendorf blumendorf deleted the chore/update-documentation-2 branch December 9, 2019 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelbieh manuelbieh Awaiting requested review from manuelbieh

1 more reviewer

@drinchev drinchev drinchev approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blumendorf @drinchev