-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo fixes #1169
Typo fixes #1169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 1583ada
I trust you with the LaTeX fixes, but I feel that we need something in the CI to check for this kind of typo. It seems really easy to make this kind of mistake.
This commit doesn't change the logic at all, it simply: - removes `realm` from onion test vector - cleans-up markdown formatting and indents - fixes typos and missing parenthesis - consistently uses `_` instead of `-` for field names - fixes math formatting (including changes from lightning#1169 and lightning#1158)
This commit doesn't change the logic at all, it simply: - removes `realm` from onion test vector - cleans-up markdown formatting and indents - fixes typos and missing parenthesis - consistently uses `_` instead of `-` for field names - fixes math formatting (including changes from lightning#1169 and lightning#1158)
The LateX fixes were included in #1181, so it looks like you can rebase to just keep the tiny changes to Bolt 3? |
All the test vectors use static keys now, which are listed above already as the local_payment_basepoint and remote_payment_basepoint. The keys listed here are the pre-static rotated ones: if you use these, the vectors don't work! We actually use the same basepoint for the HTLCs, but never spelled it out. So do that now, and these are the local/remote htlc keys. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
1583ada
to
fb2f055
Compare
No description provided.