Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fixes #1169

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Typo fixes #1169

merged 1 commit into from
Aug 16, 2024

Conversation

rustyrussell
Copy link
Collaborator

No description provided.

@rustyrussell rustyrussell added the spelling These changes may be merged without additional sign off from the weekly meeting label Jun 11, 2024
Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1583ada

I trust you with the LaTeX fixes, but I feel that we need something in the CI to check for this kind of typo. It seems really easy to make this kind of mistake.

@t-bast
Copy link
Collaborator

t-bast commented Jun 11, 2024

The LateX fixes are a duplicate subset of #1158, which is stuck because the author is unresponsive. Can you grab the other changes from #1158 and fix the remaining comments on that PR, and we should be good to go?

t-bast added a commit to t-bast/bolts that referenced this pull request Jul 11, 2024
This commit doesn't change the logic at all, it simply:

- removes `realm` from onion test vector
- cleans-up markdown formatting and indents
- fixes typos and missing parenthesis
- consistently uses `_` instead of `-` for field names
- fixes math formatting (including changes from lightning#1169 and lightning#1158)
rustyrussell pushed a commit to rustyrussell/lightning-rfc that referenced this pull request Jul 17, 2024
This commit doesn't change the logic at all, it simply:

- removes `realm` from onion test vector
- cleans-up markdown formatting and indents
- fixes typos and missing parenthesis
- consistently uses `_` instead of `-` for field names
- fixes math formatting (including changes from lightning#1169 and lightning#1158)
rustyrussell pushed a commit that referenced this pull request Jul 17, 2024
This commit doesn't change the logic at all, it simply:

- removes `realm` from onion test vector
- cleans-up markdown formatting and indents
- fixes typos and missing parenthesis
- consistently uses `_` instead of `-` for field names
- fixes math formatting (including changes from #1169 and #1158)
@t-bast
Copy link
Collaborator

t-bast commented Jul 17, 2024

The LateX fixes were included in #1181, so it looks like you can rebase to just keep the tiny changes to Bolt 3?

All the test vectors use static keys now, which are listed above
already as the local_payment_basepoint and remote_payment_basepoint.
The keys listed here are the pre-static rotated ones: if you use
these, the vectors don't work!

We actually use the same basepoint for the HTLCs, but never spelled it
out.  So do that now, and these are the local/remote htlc keys.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell merged commit 5dec5eb into lightning:master Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spelling These changes may be merged without additional sign off from the weekly meeting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants