LDK 0.0.117 #139
Merged
LDK 0.0.117 #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 831ad69 support was added for handling traits with supertraits of supertraits, but the full patch was not applied to the C# bindings, which is finished here.
These were added at various points upstream and were never added to C#
C# doesn't have a way to pass arrays with a length, so we simply re-use the TypeScript Array/String passing, which will be usable with a CustomMarshaler on the C# side.
We had a user report this was broken, but it appears to be working fine in this case here.
These can generate a warning in calling methods that actually don't allow null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS CI is failing cause github broke access to github from github yet again, but the bins are all deterministic per https://github.com/TheBlueMatt/ldk-garbagecollected/actions/runs/6460504708