Initial 0.0.118.0-alpha0 C# Release #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C# doesn't let us pass arbitrary C# objects over the FFI as a pointer, at least not easily, so instead we need something that looks much more like what we do for TypeScript. Here we rewrite the trait handling in C# based on the TypeScript code and instead store weak pointers so we can reference trait implementation instances by a single `long`.
Using the marshallers properly will be a ton of additional work, and its not clear we can do it in the C -> C# direction anyway. Instead, we can trivially just use the TypeScript conversion logic which converts everything through pointers anyway. We'd previously done this on the C side of things, but here we do it on the C# side as well.
Given we now do array/string conversion using the TypeScript logic we no longer need to use the C# marshalling nonsense, which we remove the remnants of here.
Also fixes a mono-csc argument error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It leaks memory like a sieve, but it seems to work