Deprecate pay_for_offer_from_human_readable_name
#4083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for assigning @tnull as a reviewer! |
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
While its cool to have a super trivial API to initiate payment to a `HumanReadableName`, most wallets ultimately support multiple payment instruction formats (eg on-chain) or multiple HRN resolution schemes (eg LN-Address). Thus, we generally don't expect this API to get a lot of use. Meanwhile, we've now ended up with both a `ChannelManager::pay_for_offer_from_hrn` and `ChannelManager::pay_for_ofer_from_human_readable_name`, which is incredibly confusing. Here, we deprecate `pay_for_offer_from_human_readable_name`, pushing folks to the `bitcoin-payment-instructions` crate instead. Because it has outbound payment states associated with it it may be some time before we can fully remove all the pieces of it, sadly.
TheBlueMatt
force-pushed
the
2025-09-deprecate-direct-chanman-hrn-resolution
branch
from
ab4e768 to
cface29
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4083 +/- ##
==========================================
- Coverage 88.60% 88.60% -0.01%
==========================================
Files 176 176
Lines 132086 132086
Branches 132086 132086
==========================================
- Hits 117041 117040 -1
+ Misses 12376 12372 -4
- Partials 2669 2674 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
CI failure seems unrelated: #4085 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While its cool to have a super trivial API to initiate payment to a
HumanReadableName, most wallets ultimately support multiple payment instruction formats (eg on-chain) or multiple HRN resolution schemes (eg LN-Address). Thus, we generally don't expect this API to get a lot of use.Meanwhile, we've now ended up with both a
ChannelManager::pay_for_offer_from_hrnandChannelManager::pay_for_ofer_from_human_readable_name, which is incredibly confusing.Here, we deprecate
pay_for_offer_from_human_readable_name, pushing folks to thebitcoin-payment-instructionscrate instead. Because it has outbound payment states associated with it it may be some time before we can fully remove all the pieces of it, sadly.