Skip to content

scripts: Replace sh with bash to fix syntax error #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2023
Merged

scripts: Replace sh with bash to fix syntax error #18

merged 1 commit into from
Jun 22, 2023

Conversation

itsrachelfish
Copy link
Contributor 

scripts/generate_types.sh: 36: [[: not found
scripts/generate_types.sh: 38: [[: not found
Cannot download protoc. Linux is not currently supported by ts-protoc-gen

I ran into this bug while trying to generate new proto files on Linux. It turns out sh does not support the [[ ... ]] syntax, but bash does.

Screenshot from 2023-06-16 03-21-51

@itsrachelfish itsrachelfish requested a review from jamaljsr June 16, 2023 09:47
@jamaljsr jamaljsr force-pushed the bash-syntax-error branch from 67bb459 to d34324d Compare June 22, 2023 18:28
@jamaljsr
Copy link
Member

Rebased on master to resolve merge conflicts.

@jamaljsr jamaljsr merged commit 550f0cd into main Jun 22, 2023
@jamaljsr jamaljsr deleted the bash-syntax-error branch June 22, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamaljsr jamaljsr jamaljsr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itsrachelfish @jamaljsr