Skip to content

Conversation

ViktorT-11
Copy link
Collaborator

This PR bumps lnc-core to v0.3.2-alpha.

@ViktorT-11 ViktorT-11 changed the title lnc-core: update version to `v0.3.2-alpha lnc-core: update version to v0.3.2-alpha Jul 26, 2024
@ViktorT-11 ViktorT-11 requested a review from jamaljsr July 26, 2024 15:20
Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release tags in the package.json file are only used to download the protos that are compatible with the corresponding litd version. We don't need to be 100% precise on the exact commit hash, as long as the protos match.

@ViktorT-11 ViktorT-11 force-pushed the 2024-07-bump-version-to-v.0.3.2-alpha branch from e40d50a to 27ef73a Compare July 29, 2024 09:50
@ViktorT-11 ViktorT-11 requested a review from jamaljsr July 29, 2024 14:50
Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK LGTM 🚀

Tested this and lightninglabs/lnc-web#114 together via TW. It all works great.

@ViktorT-11
Copy link
Collaborator Author

Thanks for the review @jamaljsr! Merging

@ViktorT-11 ViktorT-11 merged commit 5159eea into main Jul 29, 2024
@jamaljsr jamaljsr deleted the 2024-07-bump-version-to-v.0.3.2-alpha branch September 9, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants