Skip to content

Conversation

jamaljsr
Copy link
Member

@jamaljsr jamaljsr commented Sep 23, 2025

This is a follow-up to #123. I discovered an issue with the webpack build output. The index.d.ts file was being placed at dist/lib/index.d.ts instead of dist/index.d.ts, which is what the package.json defines as the entrypoint for types. This was because the TS test files, that were added in #123, were being included in the output. This is unnecessary and it causes errors when apps like Terminal import this package.

The fix is pretty simple. We just need to exclude *.test.ts files from the build output.

Before (wrong):
image

After (correct):
image

Steps to test

Just run yarn build and confirm that the dist/index.d.ts file exists and there are no *.test.d.ts files in the dist/dir.

@jamaljsr jamaljsr self-assigned this Sep 24, 2025
@jamaljsr jamaljsr requested review from jbrill and dstrukt September 24, 2025 12:17
Copy link

@jbrill jbrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple change -- LGTM 👍

@jamaljsr jamaljsr merged commit 42bd332 into main Sep 24, 2025
6 checks passed
@jamaljsr jamaljsr deleted the fix-build-output branch September 24, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants