staticaddr: ignoreUnknown flag for DepositsForOutpoints

[hieblmi]

When the client evaluates signature requests for batches that include multiple unrelated inputs the client should ignore those when checking for correct change.

[gemini-code-assist]

Summary of Changes

Hello @hieblmi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the DepositsForOutpoints function by introducing an ignoreUnknown flag. This flag provides more granular control over how the system handles outpoints that are not found in the deposit store. Specifically, it allows certain operations, like checking for correct change in batches with potentially unrelated inputs, to proceed by ignoring unknown outpoints rather than failing. This improves the robustness and flexibility of deposit management within the system.

Highlights

• DepositsForOutpoints Function Update: The DepositsForOutpoints function now accepts an ignoreUnknown boolean parameter, allowing callers to control error handling for unknown outpoints.
• Flexible Error Handling: When ignoreUnknown is true, the function will skip outpoints that are not found in the deposit store (e.g., sql.ErrNoRows, pgx.ErrNoRows) instead of returning an error.
• checkChange Adaptation: The checkChange function in staticaddr/loopin/manager.go now utilizes the ignoreUnknown flag, setting it to true to gracefully handle unrelated inputs during signature request evaluation.
• Explicit ignoreUnknown Usage: Other calls to DepositsForOutpoints (e.g., in ListUnspentDeposits and handleLoopInSweepReq) explicitly set ignoreUnknown to false, maintaining existing strict error behavior where appropriate.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces an ignoreUnknown flag to the DepositsForOutpoints function, allowing callers to skip over outpoints that are not found in the database. This is a useful addition, particularly for handling batched transactions with mixed inputs. The implementation is correct and addresses the intended use case. My review includes a few suggestions to improve code clarity and architectural layering, such as inlining boolean flags and abstracting database-specific errors.

[bhandras]

LGTM 🎉