lsat: add stream interceptor #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpaulino
reviewed
Feb 5, 2020
guggero
force-pushed
the
stream-interceptor
branch
from
ba35741 to
f5f9328
Compare
To make the code easier to be reused for the upcoming stream interceptor, all generic information about the interceptor's context is extracted into a struct and the helper methods are adapted to work with that struct.
guggero
force-pushed
the
stream-interceptor
branch
from
f5f9328 to
93a8189
Compare
wpaulino
reviewed
Feb 6, 2020
| defer cancel() | ||
|
|
||
| // Run through the test cases. | ||
| for _, tc := range testCases { |
There was a problem hiding this comment.
Looks like we could refactor this further into another helper testInterceptor and invoke that here with the differences between and TestUnaryInterceptor and TestStreamInterceptor?
guggero
force-pushed
the
stream-interceptor
branch
from
93a8189 to
79c54b9
Compare
wpaulino
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a new stream intercept method to our interceptor that can attach the LSAT to a stream as well as an unary call.