Prepare for lnd v0.13.0 and upcoming LiT version #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbosworth
approved these changes
May 17, 2021
|
Is this a breaking change for users on lnd 0.11.0? |
|
Yes, users of |
carlaKC
approved these changes
May 18, 2021
bhandras
approved these changes
May 18, 2021
|
Thanks for the reviews! Please wait with merging this. I think we need some fix for the "wait for lnd to be unlocked" forward compatibility for lnd |
This commit bumps the _compile time_ version of lnd to v0.13.0-beta.rc2. This does not have an effect on the user, the run time backward compatibility will be preserved. Only the next commit will bump that minimum version.
The version v0.10.1-beta of lnd is quite old with v0.13.0-beta just being published as RC2. Maintaining backward compatibility in the lndclient library is quite an effort. We decided to merge the v0.11.1 branch into master meaning that all our projects now have this minimum version requirement.
|
Updated |
carlaKC
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to publish a version of LiT that contains
lnd v0.13.0-betasoon. To make sureloopdis compile time ready for that version oflndwe need to bump the dependency version.We also decided to make the
lndversionv0.11.1-betathe oldest that's supported bylndclient, this implicitly also means we need to bump the minimum run time version oflndtov0.11.1-beta.Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes