Skip to content

Conversation

GeorgeTsagk
Copy link
Member

@GeorgeTsagk GeorgeTsagk commented Apr 11, 2023

Description

Adds a new type of autoloop which is easier to setup. The only option is the target hot wallet size which is the maximum amount of funds we want to keep on the lightning node. If that target is exceeded a loop-out will automatically move those funds to an on-chain address.

TODOs

  • Add inactive peer auto-closer
  • Add tests

@GeorgeTsagk GeorgeTsagk self-assigned this Apr 11, 2023
@GeorgeTsagk GeorgeTsagk changed the title WIP: Autoloop rework WIP: Autoloop rework -- easy autoloop Apr 11, 2023
@GeorgeTsagk GeorgeTsagk marked this pull request as ready for review May 3, 2023 13:57
@GeorgeTsagk GeorgeTsagk changed the title WIP: Autoloop rework -- easy autoloop Autoloop rework -- easy autoloop May 3, 2023
@GeorgeTsagk GeorgeTsagk requested a review from bhandras May 3, 2023 14:06
@bhandras bhandras requested a review from sputn1ck May 3, 2023 14:28
Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start but needs a bit more explanation on the semantics of the new easy mode in the PR description as well as more discussion may be needed whether we should also support easy auto loopins?

More test coverage is also very welcome!

@GeorgeTsagk GeorgeTsagk force-pushed the autoloop-rework branch 2 times, most recently from ff7661a to ddc1c4d Compare May 5, 2023 12:35
@GeorgeTsagk GeorgeTsagk requested a review from bhandras May 5, 2023 12:38
Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready, just a few remaining nits! 🎉

Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready, just a few remaining nits! 🎉

@GeorgeTsagk GeorgeTsagk force-pushed the autoloop-rework branch 2 times, most recently from 6c8570e to 5940d13 Compare May 16, 2023 16:58
@GeorgeTsagk GeorgeTsagk requested a review from bhandras May 16, 2023 16:59
Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @GeorgeTsagk! LGTM 🎉

Copy link
Member

@sputn1ck sputn1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

very nice and easy to follow changes.

The rebase will kick travis again.

Could you add a summary / usage to the release notes?

This commit introduces the new parameters to the protofiles and the
cmd interface. If easy autoloop is enabled we just ignore the rest of
the rules and use the defaults of easy autoloop.
Adds the easy autoloop function which executes a budget update and the
best easy-autoloop swap. The easy-autoloop function re-uses functions
used in the normal autoloop that relate to on-going swaps and traffic
summary.
@GeorgeTsagk GeorgeTsagk merged commit cb8975d into lightninglabs:master May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants