-
Notifications
You must be signed in to change notification settings - Fork 121
Autoloop rework -- easy autoloop #567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoloop rework -- easy autoloop #567
Conversation
8750e79
to
82cca98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start but needs a bit more explanation on the semantics of the new easy mode in the PR description as well as more discussion may be needed whether we should also support easy auto loopins?
More test coverage is also very welcome!
ff7661a
to
ddc1c4d
Compare
ddc1c4d
to
5594ea0
Compare
5594ea0
to
12d724a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost ready, just a few remaining nits! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost ready, just a few remaining nits! 🎉
6c8570e
to
5940d13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @GeorgeTsagk! LGTM 🎉
5940d13
to
0452e5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
very nice and easy to follow changes.
The rebase will kick travis again.
Could you add a summary / usage to the release notes?
99cd376
to
73cba83
Compare
This commit introduces the new parameters to the protofiles and the cmd interface. If easy autoloop is enabled we just ignore the rest of the rules and use the defaults of easy autoloop.
Adds the easy autoloop function which executes a budget update and the best easy-autoloop swap. The easy-autoloop function re-uses functions used in the normal autoloop that relate to on-going swaps and traffic summary.
73cba83
to
5edc39d
Compare
Description
Adds a new type of autoloop which is easier to setup. The only option is the target hot wallet size which is the maximum amount of funds we want to keep on the lightning node. If that target is exceeded a loop-out will automatically move those funds to an on-chain address.
TODOs
Add inactive peer auto-closer