Skip to content

Conversation

sputn1ck
Copy link
Member

@sputn1ck sputn1ck commented Mar 1, 2024

This PR adds the ability to set a custom address that instantout will sweep to.

@sputn1ck sputn1ck requested review from bhandras and hieblmi March 1, 2024 16:08
Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Collaborator

@hieblmi hieblmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a small error in how we check the provided sweep address.

@sputn1ck sputn1ck force-pushed the instantout_custom_addr branch from bf8c169 to a1bf79b Compare March 3, 2024 10:48
@sputn1ck sputn1ck requested a review from hieblmi March 3, 2024 10:48
@sputn1ck sputn1ck force-pushed the instantout_custom_addr branch from a1bf79b to c7087a6 Compare March 3, 2024 14:45
@sputn1ck sputn1ck force-pushed the instantout_custom_addr branch from c7087a6 to 6a62be0 Compare March 4, 2024 08:44
@sputn1ck sputn1ck requested a review from hieblmi March 4, 2024 08:47
Copy link
Collaborator

@hieblmi hieblmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great feature, LGTM

@sputn1ck sputn1ck merged commit 010b63d into lightninglabs:master Mar 4, 2024
@sputn1ck sputn1ck deleted the instantout_custom_addr branch March 4, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants