notifications: do not hog the CPU if there's no L402 token yet #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhandras
force-pushed
the
notification-no-busy-wait
branch
from
6b9f9c5 to
9bf879b
Compare
bhandras
force-pushed
the
notification-no-busy-wait
branch
from
9bf879b to
0591a94
Compare
hieblmi
approved these changes
Feb 7, 2025
| ) | ||
|
|
||
| // Start the notification runloop. | ||
| for { | ||
| // Increase the wait time for the next iteration. | ||
| backoff = waitTime + time.Duration(attempts)*time.Second | ||
| waitTime = 0 | ||
| timer := time.NewTimer(backoff) | ||
|
|
There was a problem hiding this comment.
I don't think we need the waitTime = 0 above here.
There was a problem hiding this comment.
We want to reset the waitTime here which is really used in line 224 if we were able to connect the stream but upon first read it disconnected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes