Skip to content

Conversation

ffranr
Copy link
Contributor

@ffranr ffranr commented Feb 4, 2025

  • Moved group key-related unit tests to asset/group_key_test.go.
  • Improved test naming to distinguish between V0 and V1 cases clearly.

Renamed `group_key_reveal_test.go` to `group_key_test.go` to reflect a
more general scope.
Clarify that the test applies specifically to the group key V0.
Rename `TestDeriveGroupKey` to `TestGroupKeyDerivationInvalidAsset` to
clarify that the test pertains to invalid assets and the inability to
derive group keys from/for them.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13135877926

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.01%) to 40.74%

Files with Coverage Reduction New Missed Lines %
tapchannel/aux_leaf_signer.go 2 43.08%
tapgarden/caretaker.go 4 68.11%
tapchannel/aux_invoice_manager.go 5 83.13%
Totals Coverage Status
Change from base Build 13127541505: 0.01%
Covered Lines: 26777
Relevant Lines: 65726

💛 - Coveralls

Copy link
Member

@GeorgeTsagk GeorgeTsagk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean-up! 🧹

@ffranr ffranr requested review from guggero and removed request for gijswijs February 7, 2025 12:44
@guggero guggero merged commit 303f3da into main Feb 7, 2025
18 checks passed
@guggero guggero deleted the mv-groupkey-unit-tests branch February 7, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants