watchtower/wtclient: weight + sweep pkscript fixups #2604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ession This commit changes when the sweep pkscript is assigned in the construction of the justice transaction. Currently, the sweep pkscript is assigned when the task is bound to a session. However, we will moving to an assignment where a unique sweep pkscript is used per channel to prevent address inflation. Hence, this commit makes the sweep pkscript a state dependent variable, since it can be known at the time the channel id is assigned.
4 tasks
Roasbeef
approved these changes
Feb 9, 2019
|
|
||
| t.outputs = outputs | ||
| t.blobType = session.Policy.BlobType | ||
| t.outputs = outputs |
There was a problem hiding this comment.
Any particular reason for this section of the diff? Just a line swap.
There was a problem hiding this comment.
just thought it was more logical to set blob type first, as the computed outputs depend on its value. but purely a stylistic preference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.