Skip to content

Conversation

cfromknecht
Copy link
Contributor

@cfromknecht cfromknecht commented Feb 8, 2019

This PR is an extension of #2606 and #2605, adding a CheckRemoteInit helper method to the wtwire.Init message. Once the client is merged, this will checked in three different places with in the code base, so it makes sense to centralize this logic. We also add unit tests to ensure that the combination of features bits proposed via client and server will work together from the perspective of both the client and server.

Depends on:

@Roasbeef
Copy link
Member

Roasbeef commented Feb 9, 2019

Needs a rebase! Should be g2g afterwards.

@cfromknecht cfromknecht force-pushed the wtwire-check-remote-init branch from f77779f to 4a0fc3e Compare February 9, 2019 04:02
@cfromknecht
Copy link
Contributor Author

@Roasbeef rebased, ptal

@Roasbeef Roasbeef merged commit e9fb610 into lightningnetwork:master Feb 12, 2019
@cfromknecht cfromknecht deleted the wtwire-check-remote-init branch February 12, 2019 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants