-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add sample config file #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I've been meaning to add something like this for a while now. My only substantial comment is to adequately detail the two HTLC handling modification options which have been put into place for testing purposes.
sample-lnd.conf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment should be added to detail that this option and the one above it exist primarily for testing purposes.
In the case of debughtlc
it uses the same payment hash each time. This means that intermediate nodes that see this payment hash can instantly take the funds locked within the output during the clearing phase, skipping forwarding the HTLc to any other participants.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should just skip the ones meant for testing? Testers know them anyway and it can only be confusing and take up space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove
- debughtlc
- hodlhtlc
- simnet
- regtest
to be honest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simnet
and regtest
are fine as developers may be using that locally for testing purposes. It's just the two HTLC modifiers that are only used within our automated integration tests
sample-lnd.conf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit: a new line should be added above.
32ae45e
to
77d8020
Compare
Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🤾🏻♀️
It looks like the conf file is not really parsed as TOML.. In my setup it seems to require the section prefix explicitly. [Bitcoin]
active=1 Returns While [Bitcoin]
bitcoin.active=1 works. Is this a TOML parsing problem or does it look for a command line flag explicitly? (Can look into this tonight after work.) |
That's because we add the |
In TOML, the |
No description provided.